Add block-number along with validation code for a given TXID #2614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add committing block number, along with validation code for a given TXID Signed-off-by: manish <manish.sethi@gmail.com>
manish-sethi
force-pushed
the
add_blk_number
branch
from
d3fa9b8
to
a26dd62
Compare
bestbeforetoday
approved these changes
Jun 1, 2021
mastersingh24
approved these changes
Jun 1, 2021
| @@ -444,6 +448,11 @@ func retrieveTxID(encodedTxIDKey []byte) (string, error) { | |||
| return string(remainingBytes[:int(txIDLen)]), nil | |||
| } | |||
|
|
|||
| func retrieveBlockNum(encodedTxIDKey []byte, BlkNumStartingIndex int) (uint64, error) { | |||
There was a problem hiding this comment.
Do we really need a separate function for this? As far as I can tell, it's only has one consumer.
| @@ -93,7 +93,7 @@ func (store *BlockStore) RetrieveBlockByTxID(txID string) (*common.Block, error) | |||
| } | |||
|
|
|||
| // RetrieveTxValidationCodeByTxID returns the validation code for the specified txID | |||
| func (store *BlockStore) RetrieveTxValidationCodeByTxID(txID string) (peer.TxValidationCode, error) { | |||
| func (store *BlockStore) RetrieveTxValidationCodeByTxID(txID string) (peer.TxValidationCode, uint64, error) { | |||
There was a problem hiding this comment.
This is a change to a public method, but given Fabric is not designed to be a library, I don't think we need to document the API change.
There was a problem hiding this comment.
Good Catch! I'll fix this in a separate PR to avoid delay merging in this.
| @@ -1450,9 +1450,9 @@ func (m *mockLedger) GetBlockByTxID(txID string) (*common.Block, error) { | |||
| } | |||
|
|
|||
| // GetTxValidationCodeByTxID returns validation code of give tx | |||
| func (m *mockLedger) GetTxValidationCodeByTxID(txID string) (peer.TxValidationCode, error) { | |||
| func (m *mockLedger) GetTxValidationCodeByTxID(txID string) (peer.TxValidationCode, uint64, error) { | |||
There was a problem hiding this comment.
This is a change to a public method, but given Fabric is not designed to be a library, I don't think we need to document the API change.
This was referenced Jun 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: manish manish.sethi@gmail.com
Type of change
Description
This allows gateway to pass on additional relevant info to client and for using it for logging that could be helpful in debugging