Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: prepare for etcd version bump. #2707

Closed
wants to merge 1 commit into from

Conversation

guoger
Copy link
Member

@guoger guoger commented Jun 23, 2021

Signed-off-by: Jay Guo guojiannan1101@gmail.com

Signed-off-by: Jay Guo <guojiannan1101@gmail.com>
@guoger guoger requested a review from a team as a code owner June 23, 2021 16:15
@guoger guoger marked this pull request as draft June 23, 2021 16:17
@guoger
Copy link
Member Author

guoger commented Jun 24, 2021

/ci-run

@github-actions
Copy link

AZP build triggered!

@guoger
Copy link
Member Author

guoger commented Jul 27, 2021

/ci-run

1 similar comment
@denyeart
Copy link
Contributor

/ci-run

@denyeart
Copy link
Contributor

Not sure why the /ci-run trigger isn't working, maybe somebody from GitHub would know @lindluni

@denyeart
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@denyeart
Copy link
Contributor

@guoger Still working on this?

@guoger
Copy link
Member Author

guoger commented Sep 1, 2021

@guoger Still working on this?

sorry for late reply and yes i still have some draft code laying around.

missing pieces are:

  • initializing node list when etcdraft instance starts (there's a TODO in code)
  • actually bump etcd/raft lib to sane version
  • add more UTs

@Param-S
Copy link
Contributor

Param-S commented Feb 9, 2022

  • initializing node list when etcdraft instance starts (there's a TODO in code)

@guoger If I understand correctly, as per the current implementation, the consenters are set based on the config block when the raft instance gets initialized. I am trying to understand and relate the need for managing the node list in the node struct. Could you help me here to understand.

@SamYuan1990
Copy link
Contributor

hi @guoger and all,

what's the progress for this pr?
:-)

@guoger
Copy link
Member Author

guoger commented Jul 3, 2022

hi @guoger and all,

what's the progress for this pr? :-)

will revive it this week, should be able to update PR in couple of days

@denyeart
Copy link
Contributor

@guoger etcd was updated in #2997 , anything else needed for this?

@denyeart
Copy link
Contributor

denyeart commented Oct 3, 2022

@guoger Reminder...

@guoger etcd was updated in #2997 , anything else needed for this?

@denyeart
Copy link
Contributor

No response from contributor, closing.

@denyeart denyeart closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants