Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate block metadata with block while OSN catching up (backport #2748) #2757

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 15, 2021

This is an automatic backport of pull request #2748 done by Mergify.
Cherry-pick of 44ab2bf has failed:

On branch mergify/bp/release-2.3/pr-2748
Your branch is up to date with 'origin/release-2.3'.

You are currently cherry-picking commit 44ab2bf96.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   orderer/consensus/etcdraft/chain.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   integration/raft/cft_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

…#2748)

While OSN catches up replicating block from the up-to-date replica the
metadata information omitted, i.e.

```
c.support.WriteBlock(block, nil)
```

where `nil` substitutes for block's metadata.

In this commit, the consenters metadata extracted from the replicated
block and being written with the block.

Signed-off-by: Artem Barger <artem@bargr.net>
(cherry picked from commit 44ab2bf)

# Conflicts:
#	integration/raft/cft_test.go
@mergify mergify bot requested a review from a team as a code owner July 15, 2021 16:28
@mergify mergify bot added the conflicts label Jul 15, 2021
@yacovm yacovm closed this Jul 15, 2021
@mergify mergify bot deleted the mergify/bp/release-2.3/pr-2748 branch July 15, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants