[FAB-18527] Discovery supports state based endorsement queries #2764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
force-pushed
the
FAB-18527
branch
5 times, most recently
from
2485ca4
to
6cce177
Compare
andrew-coleman
previously approved these changes
Jul 19, 2021
denyeart
reviewed
Jul 19, 2021
This commit adds support for state based endorsement queries to the discovery service. When state based endorsement policies are passed in the chaincode call, discovery now combines them and then requires their combinations to be satisfied as well as the chaincode endorsement policies. Support for chaincode calls with *only* state based endorsement is future work and not implemented yet because of lack of a way to express this intent in the protobuf definition. Change-Id: I005a6abca77061cd531888cdff544691b25d09ec Signed-off-by: Yacov Manevich <yacovm@il.ibm.com>
denyeart
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for state based endorsement queries to the discovery service.
When state based endorsement policies are passed in the chaincode call,
discovery now combines them and then requires their combinations to be satisfied as well
as the chaincode endorsement policies.
Support for chaincode calls with only state based endorsement is future work and not implemented
yet because of lack of a way to express this intent in the protobuf definition.
Change-Id: I005a6abca77061cd531888cdff544691b25d09ec
Signed-off-by: Yacov Manevich yacovm@il.ibm.com