FAB-18067 Discovery support Implicit Collections #2784
Conversation
| Payload: &peer.CollectionPolicyConfig_SignaturePolicy{ | ||
| SignaturePolicy: policydsl.SignedByMspMember(mspID), | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Shouldn't you add here EndorsementPolicy field as well which would carry the same value as for the MemberOrgsPolicy. Look at the following for loop that populates the map ccMetadata.CollectionPolicie with EndorsementPolicy.
There was a problem hiding this comment.
I feel that this eventually requires an integration test somewhere.
There was a problem hiding this comment.
I've added a test to the discovery integration suite
There was a problem hiding this comment.
Thanks @andrew-coleman for adding the integration test.
One more point - I am not sure what was the motivation but it appears that we also allow the implicit collection policy to be configured via channel config.
I feel that moving the existing code in a separate function and invoking that function from both the existing code and your code may allow to keep this important logic at one place.
There was a problem hiding this comment.
Merging this as is for now. Opened a new issue so it can be tracked.
Implemented the fix as suggested by Yacov in his Jira comment. Verified the fix works against the asset-transfer-secured-agreement sample which uses implicit collections. Signed-off-by: andrew-coleman <andrew_coleman@uk.ibm.com>
andrew-coleman
force-pushed
the
implicit_collections
branch
from
6b9952b
to
dcb4e45
Compare
Implemented the fix as suggested by Yacov in his Jira comment.
Verified the fix works against the asset-transfer-secured-agreement sample which uses implicit collections.
Signed-off-by: andrew-coleman andrew_coleman@uk.ibm.com