Private Data Comparison #2861
Merged
Private Data Comparison #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcastrence
force-pushed
the
compare_snapshots_pvtdata
branch
from
a6a7f13
to
70e979b
Compare
|
@jcastrence You'll need to fix the staticcheck suggestions mentioned at https://dev.azure.com/Hyperledger/Fabric/_build/results?buildId=39933&view=logs&jobId=d3cbc547-3967-500e-4ad6-f35cc9436e08&j=d3cbc547-3967-500e-4ad6-f35cc9436e08&t=cb205cbf-7666-5009-0503-0a389840d9d5 |
jcastrence
force-pushed
the
compare_snapshots_pvtdata
branch
from
70e979b
to
4976de0
Compare
denyeart
reviewed
Aug 27, 2021
jcastrence
force-pushed
the
compare_snapshots_pvtdata
branch
2 times, most recently
from
a3861cd
to
a0cc6cb
Compare
denyeart
reviewed
Sep 2, 2021
internal/ledgerutil/compare.go
Outdated
| s.highestRecord = (*s.records)[0] | ||
| s.highestIndex = 0 | ||
| } else { | ||
| for i, r := range *s.records { |
There was a problem hiding this comment.
iterating through all the records every time is not an efficient way to do this. Better to keep the firstRecords sorted. But this could be improved in a follow-on PR since this is not the main intent of this PR.
There was a problem hiding this comment.
Agreed. The follow-on PR can implement a min-max heap to reduce runtime.
jcastrence
force-pushed
the
compare_snapshots_pvtdata
branch
from
a0cc6cb
to
e255f33
Compare
Resolves hyperledger#2818 Signed-off-by: Julian Castrence <juliancastrence@ibm.com>
jcastrence
force-pushed
the
compare_snapshots_pvtdata
branch
from
e255f33
to
bd3971b
Compare
denyeart
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2818
Signed-off-by: Julian Castrence juliancastrence@ibm.com
Type of change
Description
Related issues