Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Go modules (main) #2878

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Clean up Go modules (main) #2878

merged 1 commit into from
Aug 30, 2021

Conversation

denyeart
Copy link
Contributor

Run "go mod tidy" and "go mod vendor" on main.

Signed-off-by: David Enyeart enyeart@us.ibm.com

@denyeart
Clean up Go modules (main)
a09a818 
Run "go mod tidy" and "go mod vendor" on main.

Signed-off-by: David Enyeart <enyeart@us.ibm.com>
@denyeart denyeart requested a review from a team as a code owner August 30, 2021 17:24
@yacovm
Copy link
Contributor

yacovm commented Aug 30, 2021

Why don't we add go mod tidy diff check to CI? We used to have something like that for dep no?

@yacovm yacovm enabled auto-merge (squash) August 30, 2021 17:47
@denyeart
Copy link
Contributor Author

@yacovm there were some checks added here:
756a133

In the main case go.sum was actually ok, but there were some old vendored dependencies that are not checked.

@yacovm yacovm merged commit 7cb82ee into hyperledger:main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yacovm yacovm yacovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denyeart @yacovm