FAB-2931: do not create a chain if it's already created #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kopaygorodsky
force-pushed
the
CATBP-2931
branch
2 times, most recently
from
746a94a
to
b992541
Compare
kopaygorodsky
changed the title
kopaygorodsky
force-pushed
the
CATBP-2931
branch
from
f85446b
to
b4db335
Compare
…of chains. This can happen when in Raft protocol a channel was created, but not marked as done in WAL logs, so at orderer startup it will try to rerun creation tx and panic because the channel already exists. Signed-off-by: Vladyslav Kopaihorodskyi <vlad.kopaygorodsky@gmail.com>
kopaygorodsky
force-pushed
the
CATBP-2931
branch
from
b4db335
to
5f12590
Compare
|
Looks good to me. Let's get more eyes on this. |
ale-linux
reviewed
Sep 20, 2021
|
Looks good to me |
denyeart
approved these changes
Sep 20, 2021
|
@Mergifyio backport release-2.3 |
|
@Mergifyio backport release-2.2 |
|
Command
|
|
Command
|
|
@kopaygorodsky do you want to backport it to 1.4 and 2.2 branches? |
|
We'll have to backport to release-2.2 and release-1.4 by hand (cherry-pick), auto backport only worked on release-2.3. |
|
this should've fixed https://jira.hyperledger.org/browse/FAB-18526 as well |
|
@kopaygorodsky Reminder before we lose track of this one... if you can't find time for the remaining backports we can likely find another person... |
|
@denyeart I'll definitely find some time this weekend, had an unexpectedly busy week, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vladyslav Kopaihorodskyi vlad.kopaygorodsky@gmail.com
Type of change
Description
Do not create a new chain of type
etcdraft.Chainif such exists in the map of chains. This can happen when in Raft protocol a channel was created, but not marked as done in WAL logs. So at orderer startup, it tried to create another instance of a chain and panicked because that instance startup failed.Related issues
#2931
Release Note
Fixed bug when an orderer crashed at channel creation and after restart couldn't bootstrap because of desynchronization between WAL logs and ledger state.