Randomize selection of orderer nodes with retry #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
reviewed
Sep 28, 2021
internal/pkg/gateway/api.go
Outdated
| @@ -279,31 +280,46 @@ func (gs *Server) Submit(ctx context.Context, request *gp.SubmitRequest) (*gp.Su | |||
| return nil, status.Errorf(codes.Unavailable, "no orderer nodes available") | |||
| } | |||
|
|
|||
| orderer := orderers[0] // send to first orderer for now | |||
| // randomly shuffle orderers | |||
| rand.Shuffle(len(orderers), func(i, j int) { orderers[i], orderers[j] = orderers[j], orderers[i] }) | |||
There was a problem hiding this comment.
Instead of shuffling perhaps use rand.Perm ? It's shorter syntax and conveys better what we want to accomplish
There was a problem hiding this comment.
Yes, that's definitely neater. Thanks.
In the Submit() API method, the list of available orderers has been randomized to support improved load balancing. Retry logic has been added such that if the selected orderer fails to return a success code, then the next orderer in the list is tried. If no orderers succeed, then return an error (containing details from each orderer) to the client. Signed-off-by: andrew-coleman <andrew_coleman@uk.ibm.com>
andrew-coleman
force-pushed
the
orderer_retry
branch
from
f04e1a2
to
7df186d
Compare
yacovm
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Submit() API method, the list of available orderers has been randomized to support improved load balancing.
Retry logic has been added such that if the selected orderer fails to return a success code, then the next orderer in the list is tried. If no orderers succeed, then return an error (containing details from each orderer) to the client.
Resolves #2912
Signed-off-by: andrew-coleman andrew_coleman@uk.ibm.com