Don't use EndorseResponse.Result field #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestbeforetoday
force-pushed
the
proposal-response
branch
5 times, most recently
from
4afadb4
to
cc72314
Compare
bestbeforetoday
force-pushed
the
proposal-response
branch
2 times, most recently
from
3353afb
to
98edc37
Compare
andrew-coleman
previously approved these changes
Nov 18, 2021
This duplicates information already held within the transaction envelope, and can cause failures on gRPC message size limit with large transaction results. Also: - nil out the ProposalResponse.Response.Payload field in EndorseResponse messages since, in the successful endorsement case, this is typically populated with a duplicate of the transaction result. This field is not required by the Fabric Gateway client and can cause gRPC message size limit failures. - prefer the transaction result within the proposal response payload for EvaluateResponse messages since the Response.Payload in the proposal response is not required to be the transaction result and may instead contain metadata. Signed-off-by: Mark S. Lewis <mark_lewis@uk.ibm.com>
bestbeforetoday
force-pushed
the
proposal-response
branch
from
98edc37
to
f557fbe
Compare
andrew-coleman
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This duplicates information already held within the transaction envelope, and can cause failures on gRPC message size limit with large transaction results.
Also:
Contributes to hyperledger/fabric-gateway#316