Fix gossip unit test flake #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increasing the timeout in the gossip service unit tests appears to reduce the occurence of the flake that we frequently observe. This should be seen as a tactical fix while the underlying cause is investigated. Signed-off-by: andrew-coleman <andrew_coleman@uk.ibm.com>
yacovm
approved these changes
Feb 7, 2022
|
@Mergifyio backport release-2.4 |
|
@Mergifyio backport release-2.2 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 16, 2022
Increasing the timeout in the gossip service unit tests appears to reduce the occurence of the flake that we frequently observe. This should be seen as a tactical fix while the underlying cause is investigated. Signed-off-by: andrew-coleman <andrew_coleman@uk.ibm.com> (cherry picked from commit ab3d741)
mergify bot
pushed a commit
that referenced
this pull request
Jun 16, 2022
Increasing the timeout in the gossip service unit tests appears to reduce the occurence of the flake that we frequently observe. This should be seen as a tactical fix while the underlying cause is investigated. Signed-off-by: andrew-coleman <andrew_coleman@uk.ibm.com> (cherry picked from commit ab3d741)
✅ Backports have been created
|
ale-linux
pushed a commit
that referenced
this pull request
Jun 16, 2022
Increasing the timeout in the gossip service unit tests appears to reduce the occurence of the flake that we frequently observe. This should be seen as a tactical fix while the underlying cause is investigated. Signed-off-by: andrew-coleman <andrew_coleman@uk.ibm.com> (cherry picked from commit ab3d741)
ale-linux
pushed a commit
that referenced
this pull request
Jun 16, 2022
Increasing the timeout in the gossip service unit tests appears to reduce the occurence of the flake that we frequently observe. This should be seen as a tactical fix while the underlying cause is investigated. Signed-off-by: andrew-coleman <andrew_coleman@uk.ibm.com> (cherry picked from commit ab3d741)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing the timeout in the gossip service unit tests appears to reduce the occurence of the flake that we frequently observe.
This should be seen as a tactical fix while the underlying cause is investigated.
Signed-off-by: andrew-coleman andrew_coleman@uk.ibm.com