Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore expired CA/TLS CA certs on msp init (#3238) #3249

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

afrancoc2000
Copy link
Contributor

Adding this line guarantees that expired CA certificates wont prevent orderer initialization as happened in #3238

Type of change

Bug fix

Description

Adding this line guarantees that expired CA certificates wont prevent orderer initialization as happened in #3238

Related issues

#3238

Signed-off-by: Ana Maria Franco <afrancoc2000@gmail.com>
@afrancoc2000 afrancoc2000 requested a review from a team as a code owner February 22, 2022 13:29
Copy link
Contributor

@yacovm yacovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's have some other eyes on this.
@adecaro @ale-linux

@adecaro
Copy link
Contributor

adecaro commented Feb 23, 2022

Given my comments on the relative git issue, this looks good to me. Thanks @afrancoc2000 :)

@yacovm yacovm merged commit 0e6c8d4 into hyperledger:main Feb 23, 2022
@yacovm
Copy link
Contributor

yacovm commented Feb 23, 2022

@Mergifyio backport release-2.4

@yacovm
Copy link
Contributor

yacovm commented Feb 23, 2022

@Mergifyio backport release-2.3

mergify bot pushed a commit that referenced this pull request Feb 23, 2022
Signed-off-by: Ana Maria Franco <afrancoc2000@gmail.com>
(cherry picked from commit 0e6c8d4)
@mergify
Copy link

mergify bot commented Feb 23, 2022

backport release-2.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 23, 2022
Signed-off-by: Ana Maria Franco <afrancoc2000@gmail.com>
(cherry picked from commit 0e6c8d4)
@mergify
Copy link

mergify bot commented Feb 23, 2022

backport release-2.3

✅ Backports have been created

yacovm pushed a commit that referenced this pull request Feb 23, 2022
Signed-off-by: Ana Maria Franco <afrancoc2000@gmail.com>
(cherry picked from commit 0e6c8d4)

Co-authored-by: Ana Maria Franco <afrancoc2000@hotmail.com>
yacovm pushed a commit that referenced this pull request Feb 23, 2022
Signed-off-by: Ana Maria Franco <afrancoc2000@gmail.com>
(cherry picked from commit 0e6c8d4)

Co-authored-by: Ana Maria Franco <afrancoc2000@hotmail.com>
@denyeart
Copy link
Contributor

@Mergifyio backport release-2.2

@mergify
Copy link

mergify bot commented Feb 24, 2022

backport release-2.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 24, 2022
Signed-off-by: Ana Maria Franco <afrancoc2000@gmail.com>
(cherry picked from commit 0e6c8d4)
yacovm pushed a commit that referenced this pull request Feb 24, 2022
Signed-off-by: Ana Maria Franco <afrancoc2000@gmail.com>
(cherry picked from commit 0e6c8d4)

Co-authored-by: Ana Maria Franco <afrancoc2000@hotmail.com>
@afrancoc2000 afrancoc2000 deleted the ignore-expired-ca-tls-cert branch February 24, 2022 23:29
yeasy added a commit to yeasy/fabric-sdk-go that referenced this pull request Mar 10, 2023
This is a picked commit from

hyperledger/fabric#3249.

Fix the issue that expired certs can block using sdk.

Change-Id: Idff5f8913c772a51844b4b4d39adbfccb28d5bec
Signed-off-by: Baohua Yang <yangbaohua@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants