Node 16 and v1.4 libraries #3357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jt-nti
previously approved these changes
Apr 26, 2022
| @@ -33,6 +33,13 @@ Support for user chaincodes to utilize the chaincode shim's logger via `NewLogge | |||
|
|
|||
| For more information, check out [Logging control](./logging-control.html#chaincode). | |||
|
|
|||
| #### Nodejs v1.4 Chaincode | |||
|
|
|||
| For v1.4 Nodejs chaincode libraries, the supported node runtime is v8. Though formally unsupported, the v1.4 libraries can work on later versions. For example the Node12 runtime that was used with Fabric v2.2. Fabric v2.4 has upgraded to Node16. It is _not possible_ to run the v1.4 libraries on Node 16. Therefore any chaincode written with the v1.4 libraries will need to be updated. Typically this will be before upgrading to a Fabric 2.4 peer. | |||
There was a problem hiding this comment.
Suggested change
| For v1.4 Nodejs chaincode libraries, the supported node runtime is v8. Though formally unsupported, the v1.4 libraries can work on later versions. For example the Node12 runtime that was used with Fabric v2.2. Fabric v2.4 has upgraded to Node16. It is _not possible_ to run the v1.4 libraries on Node 16. Therefore any chaincode written with the v1.4 libraries will need to be updated. Typically this will be before upgrading to a Fabric 2.4 peer. | |
| For v1.4 Nodejs chaincode libraries, the supported node runtime is v8. Though not formally supported, the v1.4 libraries can work on later versions. For example the Node12 runtime that was used with Fabric v2.2. Fabric v2.4 has upgraded to Node16. It is _not possible_ to run the v1.4 libraries on Node 16. Therefore any chaincode written with the v1.4 libraries will need to be updated. Typically this will be before upgrading to a Fabric 2.4 peer. |
There was a problem hiding this comment.
Good spot :-) (or should I say not a bad spot?)
Clarify notes on the v1.4 Chaincode with Node16 Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
mbwhite
force-pushed
the
node-chaincode-migration
branch
from
ba171e5
to
4945cb6
Compare
andrew-coleman
approved these changes
Apr 26, 2022
|
@Mergifyio backport release-2.4 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
Clarify notes on the v1.4 Chaincode with Node16 Signed-off-by: Matthew B White <whitemat@uk.ibm.com> (cherry picked from commit f30d3cd)
denyeart
pushed a commit
that referenced
this pull request
Apr 26, 2022
Clarify notes on the v1.4 Chaincode with Node16 Signed-off-by: Matthew B White <whitemat@uk.ibm.com> (cherry picked from commit f30d3cd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify notes on the v1.4 Chaincode with Node16
Signed-off-by: Matthew B White whitemat@uk.ibm.com