Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update consensus_FAQ.md: Changed Text mentioning "Three" to "Two" algorithms #4

Closed
wants to merge 1 commit into from

Conversation

msoumeit
Copy link

@msoumeit msoumeit commented Oct 20, 2016

Description

The text says that there are three consensus implementations but actually there are only two implementations as of now.

Motivation and Context

The change improves the documentation.

Signed-off-by: Sumit Mehrotra sumit@sumitmehrotra.com

@hurf
Copy link

hurf commented Oct 21, 2016

Thanks for the contribution, but it's only a read-only mirror. You can go to Gerrit and submit the patch.

@ghost ghost closed this Oct 21, 2016
ghost pushed a commit that referenced this pull request Jan 21, 2018
This changes the main Vagrant mount point to hyperledger to provide
access to all present hyperledger repositories, including
fabric-samples.
This will give access to new repos as they are added without requiring
a modification of the Vagrantfile every time.

Patch-set #1: adds fabric-samples to the list of mounted volumes if it exists
Patch-set #2: fixes commit message
Patch-set #3: changes strategy, mounting the parent directory to be future proof
Patch-set #4: removed unrelated changes committed by error

Change-Id: If126bd9d6d8806f149a0e6bacb1d8d34875f7ba4
Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
ghost pushed a commit that referenced this pull request Feb 18, 2019
This is the fourth of four (4/4) sub-tasks that focus on
the "green" path of consensus-type migration from Kafka to Raft.

By "green" we mean that there are no failures or aborts along the
way. The 4 sub-tasks are staged in a way that minimizes dependencies
between them.

In this sub-task we introduce changes to the etcd/raft-base OSNs such
that they can restart from a ledger that was started as Kafka, migrated,
and restarted. This change concludes all the changes needed to implement
the green path on the "Raft" side.

See respective JIRA item for further details.

Change-Id: I5b408e1cfcb8cf42c39bed4df6c5496792175ef0
Signed-off-by: Yoav Tock <tock@il.ibm.com>
ghost pushed a commit that referenced this pull request Feb 18, 2019
ghost pushed a commit that referenced this pull request Mar 4, 2019
This is the fourth of four (4/4) sub-tasks that focus on
the "green" path of consensus-type migration from Kafka to Raft.

By "green" we mean that there are no failures or aborts along the
way. The 4 sub-tasks are staged in a way that minimizes dependencies
between them.

In this sub-task we introduce changes to the etcd/raft-base OSNs such
that they can restart from a ledger that was started as Kafka, migrated,
and restarted. This change concludes all the changes needed to implement
the green path on the "Raft" side.

See respective JIRA item for further details.

Change-Id: I5b408e1cfcb8cf42c39bed4df6c5496792175ef0
Signed-off-by: Yoav Tock <tock@il.ibm.com>
ghost pushed a commit that referenced this pull request Apr 11, 2019
In preparation to the alternative migration design (v2),
revert some of the commits already merged.

Kafka to Raft migration v1 - cleanup #2
Clean Kafka2Raft green path #4 (of v1)

Clean commit
0504983

Change-Id: Ic7274401fdc58870c997b3204c21f548c7f5d1af
Signed-off-by: Yoav Tock <tock@il.ibm.com>
ghost pushed a commit that referenced this pull request Apr 11, 2019
In preparation to the alternative migration design (v2),
revert some of the commits already merged.

Kafka to Raft migration v1 - cleanup #4
Remove migration package

clean commits:
9002e75
a0a9189
2d924d0
15bf213

Change-Id: I4c222852f7f686d121b4f95e5c00b4d7f22d56a8
Signed-off-by: Yoav Tock <tock@il.ibm.com>
ghost pushed a commit that referenced this pull request Apr 11, 2019
* changes:
  FAB-15045 Mig-v1 cleanup #4
  FAB-15044 Mig-v1 cleanup #3
ghost pushed a commit that referenced this pull request Jun 7, 2019
In preparation to the alternative migration design (v2),
revert some of the commits already merged.

Kafka to Raft migration v1 - cleanup #2
Clean Kafka2Raft green path #4 (of v1)

Clean commit
0504983

Change-Id: Ic7274401fdc58870c997b3204c21f548c7f5d1af
Signed-off-by: Yoav Tock <tock@il.ibm.com>
ghost pushed a commit that referenced this pull request Jun 7, 2019
In preparation to the alternative migration design (v2),
revert some of the commits already merged.

Kafka to Raft migration v1 - cleanup #4
Remove migration package

clean commits:
9002e75
a0a9189
2d924d0
15bf213

Change-Id: I4c222852f7f686d121b4f95e5c00b4d7f22d56a8
Signed-off-by: Yoav Tock <tock@il.ibm.com>
ghost pushed a commit that referenced this pull request Jun 7, 2019
…release-1.4

* changes:
  FAB-15511 Kafka2Raft-V1 cleanup #5
  FAB-15045 Mig-v1 cleanup #4
  FAB-15044 Mig-v1 cleanup #3
  FAB-15043 Mig-v1 cleanup #2
  FAB-14700  Kafka2Raft validate broadcast
ZhAnGeek pushed a commit to ZhAnGeek/fabric that referenced this pull request Oct 16, 2021
andrew-coleman pushed a commit to andrew-coleman/fabric that referenced this pull request Jun 20, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants