[Fix]: Provide a meaningful error for cert sanitization #4307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit takes care to handle the error where certificate sanitization procedure fails to construct certificate chain due to misconfiguration. Before this commit, the peer will simply fail with panic without clear explanation of what exactly was wrong. Addresses (hyperledger#4302). Signed-off-by: Artem Barger <artem@bargr.net>
yacovm
reviewed
Jul 3, 2023
| // to sanitize the cert whenever it's intermediate or leaf certificate | ||
| parentCert := chain[1] | ||
| var parentCert *x509.Certificate |
There was a problem hiding this comment.
i think it's safe to merge since if it's not at least of size 1, it crashes... right?
yacovm
approved these changes
Jul 3, 2023
|
LGTM, maybe also @ale-linux can take a look |
|
@denyeart this should probably be backported, and reviewed again by someone else |
pfi79
pushed a commit
to scientificideas/fabric
that referenced
this pull request
Jul 10, 2023
…4307) This commit takes care to handle the error where certificate sanitization procedure fails to construct certificate chain due to misconfiguration. Before this commit, the peer will simply fail with panic without clear explanation of what exactly was wrong. Addresses (hyperledger#4302). Signed-off-by: Artem Barger <artem@bargr.net> (cherry picked from commit ffc6803)
|
@Mergifyio backport release-2.5 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 19, 2023
This commit takes care to handle the error where certificate sanitization procedure fails to construct certificate chain due to misconfiguration. Before this commit, the peer will simply fail with panic without clear explanation of what exactly was wrong. Addresses (#4302). Signed-off-by: Artem Barger <artem@bargr.net> (cherry picked from commit ffc6803)
|
LGTM, backported to release-2.5. |
denyeart
pushed a commit
that referenced
this pull request
Jul 19, 2023
This commit takes care to handle the error where certificate sanitization procedure fails to construct certificate chain due to misconfiguration. Before this commit, the peer will simply fail with panic without clear explanation of what exactly was wrong. Addresses (#4302). Signed-off-by: Artem Barger <artem@bargr.net> (cherry picked from commit ffc6803)
pfi79
added a commit
to scientificideas/fabric
that referenced
this pull request
Jul 20, 2023
* release-2.5: Bump Go to 1.20.6 (release-2.5) (hyperledger#4322) [Fix]: Provide a meaningful error for cert sanitization (hyperledger#4307) # Conflicts: # .github/workflows/release.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit handles the error where the certificate sanitization procedure fails to construct the certificate chain due to misconfiguration. Before this commit, the peer will simply fail with panic without a clear explanation of what exactly was wrong.
Addresses (#4302).