CFT Block Puller: reset total sleep #4402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
10 tasks
tock-ibm
force-pushed
the
bft-bp-exceeded-reset
branch
3 times, most recently
from
c80a587
to
d24cf58
Compare
tock-ibm
force-pushed
the
bft-bp-exceeded-reset
branch
from
d24cf58
to
66333d9
Compare
tock-ibm
force-pushed
the
bft-bp-exceeded-reset
branch
3 times, most recently
from
5d261ee
to
270bf41
Compare
yacovm
previously approved these changes
Nov 15, 2023
When a block arrives, reset the total sleep time. Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: I340cd3f6026f68e31af72410f5f42790d8d429d9
tock-ibm
force-pushed
the
bft-bp-exceeded-reset
branch
from
270bf41
to
71b7fda
Compare
yacovm
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
In internal/pkg/peer/blocksprovider/deliverer.go:150
Local variable
totalDurationmeasures the total sleep during retries. If it exceedsreconnectTotalTimeThresholdthe Deliverer may exit ifMaxRetryDurationExceededHandlerreturns true.However, it does not reset on success (block reception), so
DeliverBlocks()may exit eventually if the cumulative sleep time is large, but no consecutive reconnect failure sequence exceeds the threshold for stopping retries.The solution is to reset
totalDurationtogether when we resetfailureCounter.Related issues
Issue: #4394