BFT synchronizer in orderer #4637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
reviewed
Jan 29, 2024
| @@ -110,6 +110,16 @@ func (fl *FileLedger) Height() uint64 { | |||
| return info.Height | |||
| } | |||
|
|
|||
| // GetCurrentBlockHash returns the hash of the current block's header | |||
There was a problem hiding this comment.
why do we need to expand the API of the ledger? You can just retrieve the current block, now it's cached.
There was a problem hiding this comment.
In the orderer we can, but in the peer we sometime can't, because of a snapshot. Hence, the BFTDeliverer expects this API, as it is common to the peer as well.
There was a problem hiding this comment.
Can you explain where in the production code this is used? I can't find it in the PR.
There was a problem hiding this comment.
After a second look, you are correct, this is not needed in the orderer.
I removed the respective changes to the fileledger.
tock-ibm
force-pushed
the
bft-synchronizer
branch
from
7990af3
to
a9b369e
Compare
tock-ibm
force-pushed
the
bft-synchronizer
branch
from
a9b369e
to
d9144bc
Compare
Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: If590c9d4ed727f7c2805142dde36cef3c3f14fb1
tock-ibm
force-pushed
the
bft-synchronizer
branch
from
d9144bc
to
c93202a
Compare
Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: Ic1a08b1d71ce4566b24f8a4f484f5831d94d3e07
tock-ibm
force-pushed
the
bft-synchronizer
branch
from
c93202a
to
8d9d0c5
Compare
Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: Iaecd27c0295748f94947f5af94a7385ca455f245
Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: I20182b39eafeb5465fb37d1248cdb70b025dc55c
tock-ibm
force-pushed
the
bft-synchronizer
branch
from
8d9d0c5
to
76fbeac
Compare
|
This was completed in another branch / PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Create a BFT synchronizer for the smartbft chain
Related issues
#4566