Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFT: A BFT synchronizer for smartbft #4695

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

tock-ibm
Copy link
Contributor

Type of change

  • New feature

Description

A BFT synchronizer for smartbft

Related issues

Issue #4566

@tock-ibm tock-ibm requested a review from a team as a code owner February 25, 2024 13:55
@tock-ibm tock-ibm marked this pull request as draft February 25, 2024 15:46
This commit provides a smartbft orderer with a BFTSynchronizer.
The BFTSynchronizer is the default choice for a smartbft orderer.

Signed-off-by: Yoav Tock <tock@il.ibm.com>
Change-Id: I577c89309f469d077a9a1007d4b46fa70d7ed650
Signed-off-by: Yoav Tock <tock@il.ibm.com>
Change-Id: I3a17506964e9886e62dbb5b3e8bf8713345e43f9
@tock-ibm tock-ibm marked this pull request as ready for review March 4, 2024 13:19

func NewSyncBuffer() *SyncBuffer {
return &SyncBuffer{
blockCh: make(chan *common.Block, 10),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we increase this buffer to 100 by default? and ideally this will be configurable. can we open an issue to make this configurable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure
#4715

Copy link
Contributor

@yacovm yacovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging but let's address the comment about the buffer size in another PR and issue.

@yacovm yacovm merged commit fba6384 into hyperledger:main Mar 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants