Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up go 1.22.4 #4884

Merged
merged 1 commit into from
Jun 5, 2024
Merged

up go 1.22.4 #4884

merged 1 commit into from
Jun 5, 2024

Conversation

pfi79
Copy link
Contributor

@pfi79 pfi79 commented Jun 5, 2024

No description provided.

@pfi79 pfi79 requested review from a team as code owners June 5, 2024 06:32
go.mod Outdated
@@ -1,6 +1,6 @@
module github.com/hyperledger/fabric

go 1.22
go 1.22.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the 2 digit version here. Every other go.mod file I've seen uses the 2 digit version since new features are only introduced in major.minor releases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that.

But, I did so according to the changes in the documentation, since go version 1.21. At least that's how I understood the documentation.

https://go.dev/doc/go1.21

https://go.dev/doc/toolchain#version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for the links. I still think we should keep it at major.minor (e.g. 1.22). We have the option to include the patch version here (e.g. 1.22.4), but my opinion is that we should do that only if the patch becomes important, that is, if Fabric depends on some behavior of the patch. Since Fabric continues to work with any 1.22.x version, I think 1.22 continues to be correct here.

Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>
@denyeart denyeart merged commit bd7679d into hyperledger:main Jun 5, 2024
13 of 14 checks passed
@pfi79 pfi79 deleted the up-go-1.22.4 branch June 5, 2024 14:14
@pfi79
Copy link
Contributor Author

pfi79 commented Jun 5, 2024

@denyeart please, run manual actions vulnerability-scan

@denyeart
Copy link
Contributor

denyeart commented Jun 5, 2024

@denyeart please, run manual actions vulnerability-scan

scan run successfully.

Backported to release-2.5 in #4886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants