Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump google.golang.org/protobuf v1.34.2 #4898

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

pfi79
Copy link
Contributor

@pfi79 pfi79 commented Jun 17, 2024

Not only the package has been changed, but also some tests that were running with an error.
The problem was that at proto.Marshal in the structure the XXX_sizecache field becomes equal to 1. And in the compared structure it is early 0.

Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>
@pfi79 pfi79 requested a review from a team as a code owner June 17, 2024 11:57
@C0rWin C0rWin merged commit 2ec971e into hyperledger:main Jun 17, 2024
14 checks passed
denyeart pushed a commit to denyeart/fabric that referenced this pull request Jun 17, 2024
Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>
@pfi79 pfi79 deleted the bump-protobuf-1.34.2 branch June 17, 2024 19:40
andrew-coleman pushed a commit that referenced this pull request Jun 18, 2024
* bump google.golang.org/protobuf v1.34.2 (#4898)

Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>

* bump go.uber.org/zap v1.27.0

bump go.uber.org/zap v1.27.0.

Signed-off-by: David Enyeart <enyeart@us.ibm.com>

* bump github.com/stretchr/testify v1.9.0

bump github.com/stretchr/testify v1.9.0.

Signed-off-by: David Enyeart <enyeart@us.ibm.com>

* bump github.com/golang/protobuf v1.5.4

bump github.com/golang/protobuf v1.5.4.

Signed-off-by: David Enyeart <enyeart@us.ibm.com>

* bump golang.org/x/sync v0.7.0

bump golang.org/x/sync v0.7.0.

Signed-off-by: David Enyeart <enyeart@us.ibm.com>

---------

Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>
Signed-off-by: David Enyeart <enyeart@us.ibm.com>
Co-authored-by: pfi79 <fredprtnsk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants