Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go 1.23.0 #4953

Merged
merged 1 commit into from
Aug 16, 2024
Merged

bump go 1.23.0 #4953

merged 1 commit into from
Aug 16, 2024

Conversation

pfi79
Copy link
Contributor

@pfi79 pfi79 commented Aug 16, 2024

  1. The “GOEXPERIMENT: nocoverageredesign” section cannot be deleted yet.
  2. Tried adding the “-cover” flag when compiling the plugin. It works on simple examples, but alas not for us.
  3. Added “fetch-depth: 0” to the checkout section so that the run-unit-tests.sh script doesn't swear fatal: ambiguous argument 'HEAD^': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this:

Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>
@pfi79 pfi79 requested review from a team as code owners August 16, 2024 08:06
@C0rWin C0rWin merged commit 732369f into hyperledger:main Aug 16, 2024
14 of 15 checks passed
@pfi79 pfi79 deleted the up-go-1.23 branch August 16, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants