Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update secured_private_asset_transfer_tutorial.md #4972

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

amar141989-dev
Copy link
Contributor

Updated the document to fill the gaps in commands inputs

Type of change

  • Documentation update

Description

There were some gaps in the commands specific in the ReadMe file. Have updated those commands and working as per the underlined code output.

Additional details

  • Added environment variable ASSET_ID to store and use asset id created by fabric
  • Changed command payload for AgreeToBuy command
  • Corrected output of some commands

Updated the document to fill the gaps in commands inputs

Signed-off-by: amar141989-dev <63198412+amar141989-dev@users.noreply.github.com>
@amar141989-dev amar141989-dev requested review from a team as code owners September 4, 2024 16:33
Signed-off-by: amar141989-dev <63198412+amar141989-dev@users.noreply.github.com>
Signed-off-by: amar141989-dev <63198412+amar141989-dev@users.noreply.github.com>
Copy link
Contributor

@denyeart denyeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the latest updates this PR only changes the output fields from using underscores to camelCase.

I'm fine with that and will merge, but if you intended to do more go ahead and open another pull request.

@denyeart denyeart merged commit 7611991 into hyperledger:main Sep 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants