Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Feature/ondemand reconciler for pvtdata in blocks #4997

Open
wants to merge 3 commits into
base: release-2.3
Choose a base branch
from

Conversation

tittuvarghese
Copy link

Summary

This pull request introduces an on-demand reconciliation feature for specific blocks in Hyperledger Fabric version 2.3.2. The new command peer reconcile allows users to trigger reconciliation as needed, enhancing the efficiency and flexibility of private data management.
Changes Made

New Command: Introduced peer reconcile with the syntax:

peer reconcile -c channelName block blockNumber

Implementation: Reuses the existing reconciliation logic, ensuring consistency while allowing for targeted reconciliation of specific blocks.

Rationale
In large production environments, especially those involving private data, it is common to encounter issues where private data may be missed during the commit phase. The standard reconciliation process may not always be sufficient or timely. This new command addresses these challenges by enabling users to perform reconciliation at their discretion, ensuring that critical data is accurately reconciled when needed.
Benefits

Efficiency: Users can now perform reconciliations only when necessary, rather than relying on a standard process that may not suit all scenarios.

Flexibility: This feature empowers users to manage reconciliation based on specific block requirements, enhancing overall operational control.

@tittuvarghese tittuvarghese requested a review from a team as a code owner September 30, 2024 14:00
@denyeart
Copy link
Contributor

Thank you for the contribution. For a new feature like this there are a few things to keep in mind:

New features that impact component interfaces or introduce new commands are required to go through the RFC process. Please see the RFC guidance at https://github.com/hyperledger/fabric-rfcs and start the process by opening a fabric-rfcs pull request.

Once an RFC is approved, the initial implementation can be done in the main branch. Once merged in the main branch, the maintainers would then consider backports to prior release branches. Since release-2.3 is no longer maintained, and since release-2.5 is the long-term support release, this one could conceivably be backported to release-2.5 if the maintainers think the value exceeds the risk (any v2.x users should be updating to v2.5.x regardless to get the latest security updates).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants