Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uniqueness check in InsertOrGetFFI to match indexes #1346

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Fix uniqueness check in InsertOrGetFFI to match indexes #1346

merged 1 commit into from
Jun 19, 2023
+2 −2

Commits on Jun 19, 2023

  1. Fix uniqueness check in InsertOrGetFFI to match indexes 

    When guessing the reason for an insert conflict, the query needs to exactly match
the configured database indexes. That means that the "name" and "networkName"
queries need to both include "version" as well, otherwise we risk grabbing a
row that isn't actually a conflict.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
    @awrichar
    awrichar committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    197c4d4 View commit details
    Browse the repository at this point in the history