fix: Clean up manager creation to avoid NPEs during background start

[SamMayWork]

ref: #1585 (comment)

Without this fix when calling to create a contract manager, it's possible for both the return value and the error value to be non-nil. This ensures that strictly one or the other is set.

firefly/internal/orchestrator/orchestrator.go

Line 540 in dc97c73

or.contracts, err = contracts.NewContractManager(ctx, or.namespace.Name, or.database(), or.blockchain(), or.data, or.broadcast, or.messaging, or.batch, or.identity, or.operations, or.txHelper, or.txWriter, or.syncasync, or.cacheManager)

Need to test using the steps provided above to ensure the fix is good (also pending UT coverage).

[EnriqueL8]

Gonna have to fix the Docker image

1.121 fetch https://dl-cdn.alpinelinux.org/alpine/v3.19/community/x86_64/APKINDEX.tar.gz
1.444 ERROR: unable to select packages:
1.446   postgresql16-client-16.4-r0:
1.446     breaks: world[postgresql16-client=16.3-r0]

[SamMayWork]

Fix tested manually using the recreate from #1585 (comment) and all looks good.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dc97c73) to head (4822087).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #1586   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          337       337           
  Lines        24225     24230    +5     
=========================================
+ Hits         24225     24230    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SamMayWork]

Required to get the build working, looks like the old version of the client has been removed. A quick look through the PostgreSQL release notes for this version suggests it just contains bug fixes: https://www.postgresql.org/docs/release/16.4/

The extent of testing done on the new client version is the UTs in this repo, if there's any further testing required let me know.

[peterbroadhurst]

Thanks for the great investigation and fix 👍