Fix bug where channel view infinitely tries to load a Topic channel

iBicha · Aug 24, 2024 · 20faa01 · 20faa01
1 parent e7234c3
commit 20faa01
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,7 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-- Nothing worth mentioning yet.
+### Fixed
+
+- A bug where channel view infinitely tries to load a `Topic` channel
 
 ## [0.25.4] - 2024-08-24
 

diff --git a/playlet-lib/src/components/ContentNode/ChannelContentNode.bs b/playlet-lib/src/components/ContentNode/ChannelContentNode.bs
@@ -7,15 +7,15 @@ import "pkg:/source/utils/Locale.bs"
 import "pkg:/source/utils/Logging.bs"
 
 function LoadChannel(invidiousNode as object) as void
-    if m.contentTask <> invalid
-        m.contentTask.cancel = true
-    end if
-
     loadState = m.top.loadState
-    if loadState = FeedLoadState.Loading or loadState = FeedLoadState.Loaded
+    if loadState = FeedLoadState.Loading or loadState = FeedLoadState.Loaded or loadState = FeedLoadState.Error
         return
     end if
 
+    if m.contentTask <> invalid
+        m.contentTask.cancel = true
+    end if
+
     m.top.loadState = FeedLoadState.Loading
     m.contentTask = AsyncTask.Start(Tasks.ChannelContentTask, {
         content: m.top