Fix issue with ManipulateType
#1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1864 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 181 181
Lines 2064 2064
Branches 537 537
=========================================
Hits 2064 2064 Continue to review full report at Codecov.
|
|
@iamkun any chance you could take a look? 👀 This should be a super light types-only change and I provided sandbox URLs for the issue and the solution so you could see the tweak |
|
In fact, here's an updated sandbox with the full types, not just a demo using similar types. |
|
Thanks |
iamkun
pushed a commit
that referenced
this pull request
May 6, 2022
## [1.11.2](v1.11.1...v1.11.2) (2022-05-06) ### Bug Fixes * add OpUnitType (week) to quarterOfYear startOf/endOf types ([#1865](#1865)) ([400bc3e](400bc3e)) * Fix type issue with ManipulateType ([#1864](#1864)) ([d033dfc](d033dfc)) * fix UTC plugin .valueOf not taking DST into account ([#1448](#1448)) ([27d1c50](27d1c50))
|
🎉 This PR is included in version 1.11.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced May 20, 2024
This was referenced Jul 27, 2024
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a sandbox showing the issue and the proposed solution.
Fixes #1863
Edit: Better sandbox with relevant types