Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mark date parameter as optional in timezone plugin #2222

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

andrew-atwood-infinitusai
Copy link
Contributor

LIke dayjs(), dayjs.tz() falls back to the default time internally if no parameter is passed. But the current Typescript types do not allow for this existing, expected, and correct functionality.

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #2222 (4976246) into dev (7151139) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 4976246 differs from pull request most recent head 7b5b4c7. Consider uploading reports for the commit 7b5b4c7 to get more accurate results

@@            Coverage Diff            @@
##               dev     #2222   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          181       183    +2     
  Lines         2074      2109   +35     
  Branches       544       555   +11     
=========================================
+ Hits          2074      2109   +35     
Impacted Files Coverage Δ
src/locale/fa.js 100.00% <ø> (ø)
src/locale/en.js 100.00% <100.00%> (ø)
src/locale/fr.js 100.00% <100.00%> (ø)
src/locale/nl.js 100.00% <100.00%> (ø)
src/locale/zh-tw.js 100.00% <100.00%> (ø)
src/plugin/advancedFormat/index.js 100.00% <100.00%> (ø)
src/plugin/bigIntSupport/index.js 100.00% <100.00%> (ø)
src/plugin/objectSupport/index.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iamkun
Copy link
Owner

iamkun commented Feb 11, 2023

Thanks

@iamkun iamkun merged commit b87aa0e into iamkun:dev Feb 11, 2023
github-actions bot pushed a commit that referenced this pull request Jun 2, 2023
## [1.11.8](v1.11.7...v1.11.8) (2023-06-02)

### Bug Fixes

* .format add padding to 'YYYY' ([#2231](#2231)) ([00c223b](00c223b))
* Added .valueOf method to Duration class ([#2226](#2226)) ([9b4fcfd](9b4fcfd))
* timezone type mark `date` parameter as optional ([#2222](#2222)) ([b87aa0e](b87aa0e))
* type file first parameter date is optional in isSame(), isBefore(), isAfter() ([#2272](#2272)) ([4d56f3e](4d56f3e))
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🎉 This PR is included in version 1.11.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

ohsory1324 pushed a commit to ohsory1324/dayjs that referenced this pull request Dec 20, 2023
ohsory1324 pushed a commit to ohsory1324/dayjs that referenced this pull request Dec 20, 2023
## [1.11.8](iamkun/dayjs@v1.11.7...v1.11.8) (2023-06-02)

### Bug Fixes

* .format add padding to 'YYYY' ([iamkun#2231](iamkun#2231)) ([00c223b](iamkun@00c223b))
* Added .valueOf method to Duration class ([iamkun#2226](iamkun#2226)) ([9b4fcfd](iamkun@9b4fcfd))
* timezone type mark `date` parameter as optional ([iamkun#2222](iamkun#2222)) ([b87aa0e](iamkun@b87aa0e))
* type file first parameter date is optional in isSame(), isBefore(), isAfter() ([iamkun#2272](iamkun#2272)) ([4d56f3e](iamkun@4d56f3e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants