Add Persian Language #2514
Add Persian Language #2514
Conversation
|
Why is there an unrelated addition of an ant github workflow? |
|
Hello. I added it by mistake. |
|
"I have added the Persian language." |
|
Looks good to me, although I can't do more than read the Farsi badly out loud (I only have rather poor Arabic). اوپنفایر looks OK at least! |
There was a problem hiding this comment.
Thanks for your contribution! This looks great! I've got a couple of requests:
- For people to be able to select this translation when they setup Openfire, it needs to be added to
xmppserver/src/main/webapp/setup/index.jsp - For people to be able to select this language after setup, it needs to be added to
xmppserver/src/main/webapp/server-locale.jsp - Excuse my ignorance, but is Farsi to be displayed left-to-right or right-to-left? If it is right-to-left, you'll need to add it to this method:
org.jivesoftware.util.LocaleUtils#isLocalizedTextRTL - I have created a ticket in our issue tracker for this change. Can you please rewrite your commit message to make a reference to OF-2869? That way, it automatically pops up in our release notes.
- Can you please squash your commits into one commit? This will remove the file that was added by mistake from history.
|
It is RTL, indeed. |
Add Persian Language
Add Persian Language
Add Persian Language
|
Hey, I appreciate that you try to address every comment that I had, but I also see that you're struggling a bit. There is no shame in that. Would you prefer me fixing this PR for you? I'd be happy to help. What is the most correct name for the translation that you added?
Would you like to be credited for this change? If so, what name would you like us to use? |
The most accurate name is "Persian (Iran)." My name is Akbar Azimifar. I would be happy if my name is also mentioned as a contributor. Sorry if I might not have fully understood the issue correctly. |
This adds a new translation to Openfire: Persian (Farsi). Many thanks to Akbar Azimifar, who provided the translation!
|
I have now applied all of the little changes that I requested myself. That was easier than trying to explain to you what I think was needed - it should have saved us both some time! Again, thank you for your translation! I would be grateful if you could give tomorrow's nightly build a test, to see if the translation works properly! |
|
I am unsure about backporting this as the hope is we don't have any more 4.8 series releases? |
That's right, I thought the same. |
|
I have added the Persian language to our Transifex project page, for easier future updates. Sadly, it does not show all of the translated data yet. Hopefully, that automatically synchronizes in the future. |
|
Nightly builds of Openfire that include this language are now available on http://www.igniterealtime.org/downloads/nightly_openfire.jsp @telvideo would you mind testing one, to see if everything is in order? |
Hello, the installation was successful. It's good, but in some parts, the appearance has issues, and it doesn't display right-to-left correctly. |
|
Thank you. If I understand your comment correctly, then it is currently usable, but should be improved. I have created a new ticket for this in our issue tracker: https://igniterealtime.atlassian.net/browse/OF-2870 If you happen to be available to apply these changes, then you would be more than welcome to. :) |
Yes, it is usable and there are no issues, but it does need improvement. I will definitely contribute. Thank you. |
No description provided.