-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OF-2873 Improve debian package #2523
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a cursory look, I can't spot major issues with this, but I'm not familiar with Debian packaging at all. |
@stokito Thanks, I added you in Jira to a group that should allow issue creation there against Openfire. |
akrherz
added
the
backport 4.9
on merge, GHA will generate a PR with these changes against 4.9 branch
label
Sep 17, 2024
akrherz
approved these changes
Sep 17, 2024
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a link to the Transifex to make it easier to find. It would be great to add it also on the website.
In the README I also spitted long lines to separate lines to make it easier to read without any work wrapping.
The debian lintian reports a lot of warnings for the deb package itself and I tried to fix some of them.
The biggest change is in the last commit d530fe9
The linitan reported:
W: openfire: recursive-privilege-change "chmod -R" [postinst:39]
:Here we have a few problems:
openfire.dirs
or even better by themake install
and then deb package will contain them too./usr/share/openfire
should contain things like images and assets so it should be read only for anyone and there should be no any need to chown it to theopenfire
. I removed the chown./var/log/openfire
actually may be removed and logs by default should be printed to stdout or syslog where they can be collected by the systemd-journald and then available from thejournalctl -u openfire -f
command. This is not our business how to persist logs. The Prosody allows both: syslog and the append to a log file. This needs to be discussed separately./etc/openfire
folder is also shouldn't be writable but I see that it may be used for some backup (?). Maybe it would be better to save backups to the/var/lib/openfire
folder instead.