OF-2873 debian package

[stokito]

As a side note I recommend to install DEB and RMP plugins for IntelliJ and they can highlight some problems

[akrherz]

Does this address the debian nightly build failure from the previous PR's changes?

[stokito]

I'll fix the build later, the CI script may need to be checked

[akrherz]

the CI script may need to be checked

The bamboo CI script is simply this, after building. bash build/debian/build_debs.sh

[github-actions]

Successfully created backport PR for 4.9:

• [Backport 4.9] OF-2873 debian package #2527

[stokito]

TLDR: You need to manually delete the file on the agent /home/bamboo-agent/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMDB-JOB1/build/debian/compat. Why it wasn't deleted by the git - I have no idea. This needs to be checked on the bamboo.
Alternatively we may temporary add the deletion of the compat to the build_debs.sh.

Explanation
I removed the file build/debian/compat which shows a debhelper compatibility level. The debhelper can make some changes itself and the compat shows which one it might made. For example if it see a systemd unit file it will generate itself the postinstall hook to start the newly installed service.
It used the compat version 5 which is extremely old. I switched it version 13 that is the latest stable https://manpages.debian.org/testing/debhelper/debhelper-compat-upgrade-checklist.7.html
But also instead of the separate file the compat level now we should be specified in the control file as a dependency.

[akrherz]

Alternatively we may temporary add the deletion of the compat to the build_debs.sh.

This would be my preference to keep any "magic" from residing within bamboo configurations. Thanks for the work on this. I am testing this change now in bamboo and will PR this change, if it works, or you can PR it, whatever :)

[stokito]

I'm afraid that maybe some other removed files remains in the git working directory that may potentially cause other problems. If you can make a fresh build on an agent that would be great. Maybe something was saved in the container.
I wont sent a PR today, sorry. But tomorrow at evening I may check again

[akrherz]

Here's what the folder currently looks like on bamboo, so no compat file

$ ls -la
total 44
drwxrwxr-x 2 bamboo-agent bamboo-agent  227 Sep 18 14:45 .
drwxrwxr-x 8 bamboo-agent bamboo-agent  104 Jun 29 11:37 ..
-rw-rw-r-- 1 bamboo-agent bamboo-agent 1253 Jun 29 11:37 build_debs.sh
-rw-rw-r-- 1 bamboo-agent bamboo-agent  223 Sep 18 07:18 changelog
-rw-rw-r-- 1 bamboo-agent bamboo-agent  888 Sep 18 07:18 control
-rw-rw-r-- 1 bamboo-agent bamboo-agent  727 Sep 18 14:45 copyright
-rw-rw-r-- 1 bamboo-agent bamboo-agent  375 Jun 29 11:37 openfire.default
-rw-rw-r-- 1 bamboo-agent bamboo-agent  116 Jun 29 11:37 openfire.dirs
-rw-rw-r-- 1 bamboo-agent bamboo-agent 2690 Jun 29 11:37 openfire.init.d
-rw-rw-r-- 1 bamboo-agent bamboo-agent  320 Jun 29 11:37 openfire.links
-rw-rw-r-- 1 bamboo-agent bamboo-agent 1797 Sep 18 07:18 openfire.postinst
-rw-rw-r-- 1 bamboo-agent bamboo-agent 1010 Jun 29 11:37 openfire.postrm
-rw-rw-r-- 1 bamboo-agent bamboo-agent  844 Jun 29 11:37 rules

[akrherz]

Ah, but this exists, I think I am tracking what you are saying. tmp/debian/openfire-4.10.0/debian/compat

[stokito]

Yhe build_debs.sh didn't cleared the tmp folder for some reason 18 сент. 2024 г. 20:35:46 daryl herzmann ***@***.***>:

…

Ah, but this exists, I think I am tracking what you are saying. *tmp/debian/openfire-4.10.0/debian/compat* — Reply to this email directly, view it on GitHub[#2525 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AADFODRBTNU32SPESBD5RRLZXG2XFAVCNFSM6AAAAABOM3LNTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJZGA2DQOJQGM]. You are receiving this because you authored the thread. [Отслеживающее изображение][https://github.com/notifications/beacon/AADFODUPH4O2XUSH3Y2GWPTZXG2XFA5CNFSM6AAAAABOM3LNTSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUMTQ5MO.gif]

[akrherz]

It did clear it, the build logs indicate this is being run

test -x debian/rules
mkdir -p "."
echo 5 >debian/compat
/usr/bin/make -f debian/rules reverse-config

trying to resolve why