Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian build #2532

Merged
merged 11 commits into from
Sep 20, 2024
Merged

Debian build #2532

merged 11 commits into from
Sep 20, 2024

Conversation

stokito
Copy link
Contributor

@stokito stokito commented Sep 19, 2024

The debian/rules was lack of "catch all" rule so make clean was failed because there is no clean target in the Makefile. I fixed that.

Basically the rules file is intended to change something in the build of the original package. But here we have an own native package so the rules should be empty with the only catch all target.

Later (maybe) I'l send another PR that will remove the override_dh_install target and use instead Makefile or debian/install or even maybe that it would be possible with Maven assembly plugin. Will check.

Other commits reduce warnings and makes a build log more clear

CC @akrherz

@akrherz
Copy link
Member

akrherz commented Sep 19, 2024

Thanks @stokito , could you kindly cherry pick #2531 here, so to see things in action?

@akrherz akrherz added the backport 4.9 on merge, GHA will generate a PR with these changes against 4.9 branch label Sep 19, 2024
@stokito
Copy link
Contributor Author

stokito commented Sep 19, 2024

No, it don't work that simply :( It depends on to be runned from sources. I also had a similar problem when runned locally and can't remember now how I bypassed it. I'll check in 6 hours

@stokito stokito force-pushed the debian_build branch 7 times, most recently from 20fa039 to f0458bb Compare September 20, 2024 10:14
@akrherz
Copy link
Member

akrherz commented Sep 20, 2024

tar -xf distribution/target/dist/distribution-artifact.tar

will extract into your cwd and not into that dist folder. -C may be of usage

@stokito
Copy link
Contributor Author

stokito commented Sep 20, 2024

Could you please fix that command? I can't see what is going inside, the ls output is useless.
Except of the CI job the deb build should be totally fine

@akrherz
Copy link
Member

akrherz commented Sep 20, 2024

@stokito my suggestion for easier debugging is to add this step to the workflow prior to the step that fails

      - name: Setup upterm session
        uses: lhotari/action-upterm@v1
        with:
          limit-access-to-actor: true 

watch the build logs and when it gets to that step, the SSH command you need to run will be shown and you can ssh in and manually debug what is happening within CI at that step.

@stokito
Copy link
Contributor Author

stokito commented Sep 20, 2024 via email

@akrherz
Copy link
Member

akrherz commented Sep 20, 2024

I'll take a hack at this PR now and see how far I can get, thanks for all this effort so far!

@akrherz
Copy link
Member

akrherz commented Sep 20, 2024

sweet, now for the epic dread of having this fail in bamboo for some strange reason

@akrherz akrherz merged commit 235a433 into igniterealtime:main Sep 20, 2024
17 checks passed
Copy link

Successfully created backport PR for 4.9:

@stokito stokito deleted the debian_build branch September 20, 2024 16:03
@stokito stokito restored the debian_build branch September 20, 2024 16:03
@stokito stokito deleted the debian_build branch September 20, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.9 on merge, GHA will generate a PR with these changes against 4.9 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants