Added nucleotide color options to the preferences menu #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ences when a new renderer is instanced
|
Thanks @KevinCLydon . Re the colors, I think the simplest thing would be to just fetch the colors on each draw, I can't imagine we save much by caching these colors. I can make this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to set nucleotide color options to the preferences menu, under General > Nucleotide Colors.
Also modified SequenceRenderer to update nucleotide colors from preferences when a new SequenceRenderer is instantiated. This way, the colors will be updated when reloading the session or loading a new session. I'm not sure if this is the ideal solution to the problem of updating the colors without having to restart, so I'd be very happy to change it if there is a better way.