Remove snappy #1571
Merged
Remove snappy #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A made a change in htsjdk but I need to do a release before we can fix this branch. samtools/htsjdk#1715 |
* update htsjd 4.1.1 -> 4.1.2 which makes Snappy optional
lbergelson
force-pushed
the
lb_exclude_snappy
branch
from
b16d222
to
35c9294
Compare
lbergelson
commented
Sep 18, 2024
| @@ -359,7 +361,8 @@ tasks.register('createMacAppWithJavaDistZip', Zip) { | |||
| } | |||
| } | |||
|
|
|||
| task createWinDist(type: Copy, dependsOn: createDist) { | |||
| tasks.register('createWinDist', Copy) { | |||
There was a problem hiding this comment.
I missed these in the 21 update branch.
|
@jrobinso This removes snappy and sorting should still function ( but more slowly ). |
jrobinso
added a commit
that referenced
this pull request
Sep 27, 2024
* update htsjd 4.1.1 -> 4.1.2 which makes Snappy optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remove snappy which will hopefully fix our notarization issue.