Fix for Amazon failing. #1599
Merged
Fix for Amazon failing. #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix the amazon failures due to LogFactory not found by adding a module dependency * on apache logging. This is necessary because commons-logging became modularized * between 1.2.0 and 1.3.0 but amazon is expecting the non-modular 1.2.0 while * 1.3.0 is being brought in due to changes in htsjdk. * See https://logging.apache.org/blog/2023/12/02/apache-common-logging-1.3.0.html for * more info. * Fix for #1598
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jrobinso Can you test this on your system before we merge? It seems to fix the problem for me but I want to be sure it's also fixing it for you.