Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix for UnsupportedNodeClient case #1

Merged

Conversation

kshamenkgil
Copy link
Collaborator

Motivation

Some nodes seem to be falling outside of the NodeClient supported list, returning an UnsupportedNodeClient error when the type of node is consulted, causing the updated create_access_list function to panic.

Solution

Remove the unwrapping for node_client result and call the default "non Erigon" option for such cases.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Owner

@imbenwolf imbenwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@imbenwolf imbenwolf merged commit d7c78dd into feat/optimize-gas-access-list May 29, 2024
@imbenwolf imbenwolf deleted the fix/access-list-client-check branch May 29, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants