Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(mobile): refactor detail panel #11662

Merged
merged 12 commits into from
Aug 9, 2024
Merged

chore(mobile): refactor detail panel #11662

merged 12 commits into from
Aug 9, 2024

Conversation

alextran1502
Copy link
Contributor

@alextran1502 alextran1502 commented Aug 8, 2024 •
edited
Loading

This PR addresses many issues related to the asset detail bottom sheet, now called DetailPanel

  • Refactored each section to its component
  • Each component is rebuilt individually instead of as a whole DetailPanel.
  • Streamlined some UI components, such as the Dropdown menu corner radius.
  • Adjusted spacing when some EXIF information is missing
  • Fixed jank issue when scrolling the DetailPanel
  • The editing date and time will be reflected in the DetailPanel UI as soon as the action is completed.
  • Editing description is now updated accordingly when the sheet is reopened
  • Added animation when the people section rendered

New detail panel

Before After
old detail panel New detail panel

Edit date timesheet

Before After
Edit date time Edit date time

Location of local asset

Before After
Location of local asset Location of local asset

@alextran1502 alextran1502 marked this pull request as draft August 8, 2024 22:22
@alextran1502
Copy link
Contributor Author

Discover some bugs when running on my physical device, will need to investigate more

@alextran1502 alextran1502 marked this pull request as ready for review August 9, 2024 13:40
@alextran1502 alextran1502 enabled auto-merge (squash) August 9, 2024 13:42
@alextran1502 alextran1502 merged commit d346985 into main Aug 9, 2024
22 checks passed
@alextran1502 alextran1502 deleted the mobile/refactor-exif-sheet branch August 9, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

@martyfuhry martyfuhry Awaiting requested review from martyfuhry

@shenlong-tanwen shenlong-tanwen Awaiting requested review from shenlong-tanwen

@fyfrey fyfrey Awaiting requested review from fyfrey

Assignees
No one assigned
Labels
changelog:bugfix 📱mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alextran1502 @jrasm91