feat(web): move search options into a modal #12438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🖥️web
changelog:translation
and removed
changelog:enhancement
labels
ben-basten
force-pushed
the
feat/search-options-modal
branch
from
b0ee726
to
af017c0
Compare
ben-basten
changed the title
jrasm91
approved these changes
Sep 9, 2024
|
Thank you for the PR. One change I think would make the model look better is incorporating the scroll bar inside the modal and appearing below the curved corner. Please see the example below
|
spiceratops
added a commit
to spiceratops/k8s-gitops
that referenced
this pull request
Sep 12, 2024
…115.0 (#964) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/immich-app/immich-server](https://redirect.github.com/immich-app/immich) | minor | `v1.114.0` -> `v1.115.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>immich-app/immich (ghcr.io/immich-app/immich-server)</summary> ### [`v1.115.0`](https://redirect.github.com/immich-app/immich/releases/tag/v1.115.0) [Compare Source](https://redirect.github.com/immich-app/immich/compare/v1.114.0...v1.115.0) ### v1.115.0 > \[!NOTE] > We are working on redesigning the flows and layout of the mobile app to incorporate recently added features such as folders and tags, as well as making improvements to album management on the mobile app. We are gathering feedback in this [discussion](https://redirect.github.com/immich-app/immich/discussions/12597). We are excited to hear your feedback. Welcome to release `v1.115.0` of Immich. This release focuses on cleaning up our backlog of issues. It is also worth noting that the [Cursed knowledge page](http://immich.app/cursed-knowledge/) has been updated with *even more cursed knowledge*. Please find some of the release highlights below: - Administration button - Manually link and unlink Live motion photos - Default exclusion patterns - Start-up folder checks - Upload trash indicator Notable bug fixes include: - Signing out of the web now signs out of all tabs - Long-standing issue regarding inaccurate album asset count has been fixed - Search text is preserved when switching between "Context" and "File name or extension" - Editing a person's name or birthdate on mobile has been fixed ##### Administration button The `Administration` button on the web is now moved inside the profile sheet to clean up the top app bar and improve the navigation experience for all screen sizes. <img width="346" alt="image" src="https://github.com/user-attachments/assets/36389e3d-3fc9-4a4b-a480-f3165ec114bc"> ##### Manually link and unlink Live motion photos Live photos (iOS) can now be manually linked an unlinked. [Screencast from 09-11-2024 10:15:57 AM.webm](https://redirect.github.com/user-attachments/assets/07ec144a-af03-4827-8e6b-f2b4f30ec1f4) ##### Default exclusion patterns We have added default exclusion patterns whenever a new external library is created. By default, we exclude the `@eaDir` folder Synology uses to store miscellaneous files and any files beginning with `._`. Of course, you can edit these patterns if you want to, but this is highly unlikely.  ##### Startup folder checks Immich will now *fail to start* if it is unable to read/write to `upload/`, `library/`, `thumbs/`, `encoded-videos/` or `profile/`. Starting with this release, the server will write an `.immich` file to each of the previously listed folders. On subsequent restarts, it will *fail to start* if it fails to locate the previously written `.immich` file. This will hopefully increase transparency around situations where the `UPLOAD_LOCATION` mount is incorrectly configured or unavailable. ##### Upload trash indicator When you upload a duplicate via the web and that duplicate is in the trash, you now will see an indicator for it, along with being able to open the asset in a new tab. | Light | Dark | | - | - | |  |  | *** #### Support Immich <p align="center"> <img src="https://media.giphy.com/media/v1.Y2lkPTc5MGI3NjExbjY2eWc5Y2F0ZW56MmR4aWE0dDhzZXlidXRmYWZyajl1bWZidXZpcyZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/87CKDqErVfMqY/giphy.gif" width="450" title="SUPPORT THE PROJECT!"> </p> If you find the project helpful, you can support Immich by purchasing a product key at <https://buy.immich.app>. Cheers! 🍻 <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### 🚀 Features - feat(web): manually link live photos by [@​jrasm91](https://redirect.github.com/jrasm91) in [immich-app/immich#12514 - feat(web): unlink live photos by [@​jrasm91](https://redirect.github.com/jrasm91) in [immich-app/immich#12574 ##### 🌟 Enhancements - feat(web): logout of all tabs by [@​jrasm91](https://redirect.github.com/jrasm91) in [immich-app/immich#12407 - feat(server): start up folder checks by [@​jrasm91](https://redirect.github.com/jrasm91) in [immich-app/immich#12401 - feat(web): responsive top navigation by [@​ben-basten](https://redirect.github.com/ben-basten) in [immich-app/immich#12373 - feat(mobile): Add dismiss action on app_bar_dialog by [@​Lauritz-Tieste](https://redirect.github.com/Lauritz-Tieste) in [immich-app/immich#12511 - feat(web): select the EXIF timezone (if it exists) in dropdown by [@​C-Otto](https://redirect.github.com/C-Otto) in [immich-app/immich#12495 - fix(web): show trash indicator by [@​jrasm91](https://redirect.github.com/jrasm91) in [immich-app/immich#12521 - feat(web): move search options into a modal by [@​ben-basten](https://redirect.github.com/ben-basten) in [immich-app/immich#12438 - feat(server): default exclusion patterns by [@​etnoy](https://redirect.github.com/etnoy) in [immich-app/immich#12566 ##### 🐛 Bug fixes - fix(server): remove hidden assets from albums by [@​jrasm91](https://redirect.github.com/jrasm91) in [immich-app/immich#12449 - fix(server): handle multiple hierarchical subjects by [@​jrasm91](https://redirect.github.com/jrasm91) in [immich-app/immich#12509 - fix(mobile): scroll thumb is hidden behind the tab navigation bar by [@​alextran1502](https://redirect.github.com/alextran1502) in [immich-app/immich#12512 - fix(web): select partner assets from timeline by [@​jrasm91](https://redirect.github.com/jrasm91) in [immich-app/immich#12517 - fix(web): preserve search text by [@​jrasm91](https://redirect.github.com/jrasm91) in [immich-app/immich#12531 - fix(web): show upload error message on network error by [@​jrasm91](https://redirect.github.com/jrasm91) in [immich-app/immich#12533 - fix(server): handle invalid directory item by [@​jrasm91](https://redirect.github.com/jrasm91) in [immich-app/immich#12534 - fix(web): leave assets selected after add to album by [@​jrasm91](https://redirect.github.com/jrasm91) in [immich-app/immich#12537 - fix(server): person repo methods by [@​jrasm91](https://redirect.github.com/jrasm91) in [immich-app/immich#12524 - fix(ml): batch axis not being added for recognition model by [@​mertalev](https://redirect.github.com/mertalev) in [immich-app/immich#12588 ##### 📚 Documentation - docs: more cursed knowledge by [@​jrasm91](https://redirect.github.com/jrasm91) in [immich-app/immich#12529 - docs: proper value of word-based suggestions setting to setup VSCode by [@​sapachev](https://redirect.github.com/sapachev) in [immich-app/immich#12586 - docs: add server backup to First Steps by [@​mmomjian](https://redirect.github.com/mmomjian) in [immich-app/immich#12555 ##### 🌐 Translations - chore(web): update translations by [@​weblate](https://redirect.github.com/weblate) in [immich-app/immich#12384 #### New Contributors - [@​pbustamantes](https://redirect.github.com/pbustamantes) made their first contribution in [immich-app/immich#12486 - [@​Lauritz-Tieste](https://redirect.github.com/Lauritz-Tieste) made their first contribution in [immich-app/immich#12511 - [@​jonathanjsimon](https://redirect.github.com/jonathanjsimon) made their first contribution in [immich-app/immich#12510 - [@​sapachev](https://redirect.github.com/sapachev) made their first contribution in [immich-app/immich#12586 **Full Changelog**: https://github.com/immich-app/immich/compare/v1.114.0... </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43Ny4yIiwidXBkYXRlZEluVmVyIjoiMzguNzcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvY29udGFpbmVyIiwidHlwZS9taW5vciJdfQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving the search options into a modal, rather than displaying them below the search bar. Benefits of this change include:
Screenshots
Wide screen width
Mobile screen width