Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added Method Channel result response to null #79

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

Javidroid
Copy link

Apart from code format changes, the most important change is adding result?.success(null) to the else block of onActivityResult(...) method on Dialog.kt

This causes the MethodChannel result to return something that can be 'heard' from the outside. In this case: null.

It is specifically a 'success' instead of an 'error' as, technically, the operation was made correctly, but the user chose to cancel it, returning nothing instead.

Copy link
Owner

@incrediblezayed incrediblezayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Thanks

@incrediblezayed incrediblezayed merged commit f28b5cf into incrediblezayed:main Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants