Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "feat(execute): allocate memory for string content. (#5482)" #5502

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

mhilton
Copy link
Contributor

@mhilton mhilton commented Aug 13, 2024

This reverts commit bea9586.

This PR attempted to reduce the amount of un-accounted memory use. In doing so it introduced a significant amount of data copying. This has made the performance unacceptable. Reverting this change in order to come up with a better plan.

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

@mhilton mhilton requested a review from a team as a code owner August 13, 2024 06:24
@mhilton mhilton requested a review from btasker August 13, 2024 06:35
@mhilton mhilton merged commit 6ffcb71 into master Aug 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants