Add Redis backend #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talex5
force-pushed
the
redis
branch
2 times, most recently
from
a6c29c0
to
fb67ed9
Compare
|
A few updates:
|
|
We've been using this for a few weeks now and it seems to be working well. |
Note: - The test code checks that it gets "Expired" for expired keys. But keeping expired keys around seems pointless, so for the Redis checks I allow it to return Not_found instead.
|
Would be good to get this merged, because it's a dependency of datakit-ci and we can't release that to opam-repository until this is released. |
|
Thanks for merging! Any chance of a release in opam-repository stable containing this, so that we can release the CI software as well? |
|
Thanks! I've updated DataKitCI to use the released version. |
|
thanks @seliopou! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
The test code checks that it gets "Expired" for expired keys. But keeping expired keys around seems pointless, so for the Redis checks I allow it to return Not_found instead.
The tests assume you have a Redis server running on 127.0.0.1, which probably isn't reasonable. Maybe they should be disabled. How does it work for Postgres?
Fixes #3.
Has only been very lightly tested so far.