Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update READMEs and various config files #1

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Update READMEs and various config files #1

merged 1 commit into from
Oct 17, 2023

Conversation

notmatthancock
Copy link
Member

  • Updates contributing template to be written as step by step instructions for setting up dev environment
  • Fixes copier config yaml.
  • Fixes some things that pre-commits caught when running on a newly copied repo
  • Fixes broken import in test

Copy link
Collaborator

@phcerdan phcerdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great documentation!

@@ -1,25 +1,37 @@
_imports:
parse: packaging.version.parse
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't this working?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I couldn't find _imports documented anywhere in copier's documentation. And it turns out that YAML fields beginning with _ will be ignored during the actual copy interaction when it asks for values for the fields.

@phcerdan phcerdan merged commit 5141de8 into main Oct 17, 2023
4 checks passed
@phcerdan phcerdan deleted the make-updates branch October 17, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants