upgrade teerex refactoring #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pallet bounties benchmark failed, but that's out of scope and we leave the old weights Input("Benchmark pallet_bounties::spend_funds failed: TooManyQueued") |
brenzi
commented
Aug 9, 2023
| .saturating_add(Weight::from_parts(0, 3859)) | ||
| // Measured: `451` | ||
| // Estimated: `3916` | ||
| // Minimum execution time: 2_821_014_000 picoseconds. |
There was a problem hiding this comment.
I think that is close enough given different benchmarking machines
brenzi
commented
Aug 9, 2023
| // Proof Size summary in bytes: | ||
| // Measured: `412` | ||
| // Estimated: `3877` | ||
| // Minimum execution time: 41_875_000 picoseconds. |
There was a problem hiding this comment.
that's the platform bottleneck in terms of future congestion. benchmark is reasonably close
clangenb
approved these changes
Aug 9, 2023
| .saturating_add(Weight::from_parts(0, 3859)) | ||
| // Measured: `451` | ||
| // Estimated: `3916` | ||
| // Minimum execution time: 2_821_014_000 picoseconds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #221