-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README #96
Merged
Merged
Update README #96
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1371b25
update bad link
haerdib b651620
update launch procedure
haerdib 2594b5d
update outdated labels
haerdib 25fafa4
a little bit nicer
haerdib 87bb3c3
add release tag example
haerdib dbb394e
add cargo + nightly help
haerdib b58befc
add some better paraId reservation docs
haerdib 4d9e5f0
change order
haerdib 5a1d856
update reserve & register
haerdib 9f3821e
fix .json ending
haerdib 0c923b0
update naming
haerdib 38b0910
update bootnode options
haerdib b8224cd
add better description of relay chain port usage in polkadot js
haerdib 2a7e294
remove blow up of manual set up
haerdib 28e1ef8
some nice up ness
haerdib dd9ed11
remove 2nd polkadot launch cmd
haerdib 4cdd96c
Merge branch 'master' into bh-update-readme-v2
brenzi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer if we set a team standard here. Go with the second option but explain how to install it that way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated it accordingly. The installation needs to be globally such that the 2nd option can be used. But that's already in the installation part of polkadot-launch. So I simply put a Link there. Is that alright?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whereas "global" means "across all projects of the current user", not system-wide for all users. then it's ok as it does not demand special privileges
~/.yarn/bin/polkadot-launch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's per user. At least if yarn has been installed for per-user. It didn't require any sudo command, in my case, neither for yarn nor for polkadot-launch with
-g
option.