on block storage updates for every shard #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 3, 2020 08:58
…ollow an auto-join policy for new shards.
…sic in stf. Only log the error.
clangenb
force-pushed
the
cl-on-block-storage-updates-for-every-shard
branch
from
b2396ab
to
e8b85d4
Compare
clangenb
commented
Jun 3, 2020
| Err(_) => error!("Error executing relevant extrinsics"), | ||
| }; | ||
|
|
||
| if update_states(signed_block.block.header, node_url).is_err() { |
There was a problem hiding this comment.
@brenzi As the runtime does perform state updates at the end of block execution I suppose it does make sense that we also update the state after we executed the relevant extrinsics?
Closed
brenzi
pushed a commit
to encointer/encointer-worker
that referenced
this pull request
Sep 8, 2020
* [enclave] extracted verify worker response. * [STF/enclave] whip update storages upon block import * [enclave] perform state updates on all shards upon block import * [enclave] Create shard if it does not exist. Currently, the workers follow an auto-join policy for new shards. * clippy * [enclave] do not return an error if could not execute relevant extrinsic in stf. Only log the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the enclave does now perform a state update on every shard upon block import with the keys given by the newly introduced
STF::storage_hashes_to_update_on_blockAs of now the enclave creates a new shard if it does not exist already.
Every shard located in the
shardsdirectory is updated.