-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFCI][SYCL] Refactor getBinaryImageFormat #12586
[NFCI][SYCL] Refactor getBinaryImageFormat #12586
Conversation
A future PR will add support for magic numbers other than four bytes. Refactor the code to make those future changes easier to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good, with a few nits in #12587.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Post commit failed on Arc GPU:
I believe I've seen it before and it's not specific to this PR. |
That's what AOT for Intel GPUs produces when targeting multiple devices at once. This PR is built on top of #12586.
SYCL Nigthly failures. OpenCL CPU (on AMD runner):
OpenCL CPU (Intel Arc GPU runner):
OpenCL CPU (Intel GEN12 runner) failed due to infrastructure issues. |
Another run of SYCL Nightly (it was still latest commit over the weekend):
OpenCL CPU (Intel Arc GPU runner):
OpenCL CPU (Intel GEN12 runner) failed due to infrastructure issues. |
And the third SYCL Nightly run: OpenCL CPU (AMD runner):
OpenCL CPU (Intel Arc GPU runner):
OpenCL CPU (Intel GEN12 runner) failed due to infrastructure issues. |
A future PR will add support for magic numbers other than four bytes. Refactor the code to make those future changes easier to review.