[SYCL][ESIMD]Implement slm_scatter accepting compile time properties #12591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fineg74
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Looks like the tests are failing, I'll hold my review for now |
@fineg74 for such big code-changes please create 'Draft PR' first, then do a series of extra changes if necessary to get passes, then change draft to real PR. |
v-klochkov
reviewed
Feb 2, 2024
v-klochkov
reviewed
Feb 2, 2024
sarnex
reviewed
Feb 5, 2024
v-klochkov
reviewed
Feb 5, 2024
fineg74
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
v-klochkov
approved these changes
Feb 7, 2024
@sarnex - CI is green, please finish your code-review |
|
Will do, sorry |
sarnex
reviewed
Feb 7, 2024
| /// void slm_scatter( | ||
| /// OffsetSimdViewT byte_offsets, simd<T, N> vals, | ||
| /// PropertyListT props = {}); // (slm-sc-4) | ||
| /// Loads ("gathers") elements of the type 'T' from Shared Local Memory |
There was a problem hiding this comment.
Comment seems wrong, should be for scatter
There was a problem hiding this comment.
Please address in follow-up PR for local accessors and scatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the unified memory API for slm_scatter with local accessors