[UR][CUDA] Fix function pointer typedefs in xpti tracing #12784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Doesn't seem like the CI failures are related to this fix |
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
reviewed
Mar 13, 2024
There was a problem hiding this comment.
oneapi-src/unified-runtime#1368 has been merged, however this PR is now dependent #12833 merging first. Once the dependent PR has merged please merge in the latest sycl branch changes, update the UR repo/tag, then make this PR ready for review.
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
approved these changes
Mar 13, 2024
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers please merge |
bader
pushed a commit
that referenced
this pull request
Mar 13, 2024
Mipmap interop: - Remove "interop" image type as it is redundant for image creation - Add a vulkan mipmap interop test Slight redesign: - Simplify external resources Modify the bindless spec to reflect these changes Fix Vulkan interop tests to prevent memory leak issue by freeing mapped memory Corresponding UR PR: oneapi-src/unified-runtime#1351 Depends on #12784 merging first --------- Co-authored-by: DBDuncan <43582941+DBDuncan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI for UR PR: oneapi-src/unified-runtime#1368