fix: update parachain version (with subxt fix) #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sander2
commented
Jan 4, 2022
sander2
commented
- new metadata
- use the new currencyid type
- the parachain upgrade exposed a new subxt bug; upgrade to a new version that includes the fix I made there
gregdhill
approved these changes
Jan 4, 2022
sander2
force-pushed
the
fix/update-parachain-version
branch
from
b1d251c
to
226039d
Compare
gregdhill
reviewed
Jan 5, 2022
There was a problem hiding this comment.
Instead of conditionally compiling the faucet we could only compile it with standalone metadata, but with the new testnet runtime sudo will be available again. See: interlay/interbtc#465
sander2
force-pushed
the
fix/update-parachain-version
branch
from
226039d
to
9433bd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.