This repository has been archived by the owner on Oct 16, 2020. It is now read-only.
feat: pass config to jsipfs fallback #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olizilla
reviewed
Dec 12, 2018
| expect(res.ipfs).toEqual(mockIpfs) | ||
| expect(res.provider).toEqual('js-ipfs') | ||
| expect(opts.ipfsConnectionTest.mock.calls.length).toBe(1) | ||
| expect(opts.initJsIpfs.mock.calls.length).toBe(1) |
There was a problem hiding this comment.
We should test that the custom config gets passed to the jsipfs constructor; that the new thing that this feature adds. If you keep a ref to the jsipfs constructor mock, I believe you can assert that it was called with specific arguments.
There was a problem hiding this comment.
Hmm makes sense, but that is inside the promiseMeJsIpfs function that is outside the scope of the test. Not sure how to do that 🤔
|
Superseded by #42. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve ipfs-shipyard/ipfs-share-files#63 and to make the ipfs-redux-bundle more versatile, this PR enables passing a custom config to jsipfs!